Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ElasticSearch datacollector #3816

Closed
darthf1 opened this issue Nov 6, 2020 · 1 comment
Closed

Provide ElasticSearch datacollector #3816

darthf1 opened this issue Nov 6, 2020 · 1 comment

Comments

@darthf1
Copy link
Contributor

darthf1 commented Nov 6, 2020

Hi!

I would like to request a DataCollector for searches made with the ElasticSearch client, similar to the one provided by FOS.

I'm willing to do a PR but would love to get some pointers on this.

  • Should I add a ApiPlatform\Core\Bridge\Elasticsearch\Client, which decorates the Elasticsearch\Client and add logic there?
  • Where would you like the result to be displayed? In the already available "ApiPlatform" profiler section and do a sub-section there? Or do you want a new (ElasticSearch?) section?
  • Or something else entirely; depend on FOS and use their client. Not sure if that would be beneficient.
  • For v8 of the php-elasticsearch library they want to redesign their transport layer. See Supporting PSR-7 and PSR-18 for HTTP transport layer elastic/elasticsearch-php#990. Should I wait? Or any other things to consider?
@darthf1
Copy link
Contributor Author

darthf1 commented Nov 11, 2020

Closing. I noticed the query is already provided in the log tab of the profiler, which is sufficient for me.

@darthf1 darthf1 closed this as completed Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant