-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: avoid using yield
, which is not supported in some user cases.
#8
Comments
we can pass an array table for storing the generating Lua code. |
This is not easy, we need to be careful and add more test cases. |
Yes, I agree @membphis , I would prefer if anyone from the core team can fix it as I'm a beginner to Lua, in case if it is not in the immediate fix list, then I'll give it a try. |
waiting for your PR ^_^ |
Hi @membphis a small clarification, maybe I'm not understanding the bigger picture here, when I remove the coroutine and simply append the code chunks to a table, it produces the same results as before.
Can I know what things to watch out? and what is the reason to use coroutine here, as a table would also do the job, is it for any performance boost? |
our project base on https://github.com/jdesgats/ljsonschema , you can contact him for more detail things. As I know, use coroutine is simple but bad performance. I would like the array table way which is better performance. |
apache/apisix#1181 (comment)
The text was updated successfully, but these errors were encountered: