feat: Add response type option to endpoints #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbearman
force-pushed
the
endpoint-response-type
branch
from
ba5c303 to
c4216c0
Compare
paulsturgess
approved these changes
May 14, 2024
jimehk
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the way in which the response type is set to be part of the endpoint definition DSL, rather than at runtime via the
plain_text_bodymethod, as this allows Open API to infer the response type from the endpoint definitionThe
plain_text_bodymethod has been left in for backwards compatibility, but marked as depreciated, as it doesn't play nice with our Open API libraryOnce this is released we can update the Open API lib to support plain text responses - apiaframework/apia-openapi#62