fix: Ensure CORS headers are still added when an error occurs in the authenticator #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `rack.input` header was made optional, so we need to always set an input in our mock requests
- add_runtime_dependency is deprecated in favour of add_dependency - params are not required for `super` when the method signature is unchanged
mattbearman
force-pushed
the
add-cors-headers-to-auth-errors
branch
from
5900b5c to
9a0b16d
Compare
mattbearman
commented
Sep 12, 2024
| @@ -36,7 +36,7 @@ def json_body | |||
| end | |||
|
|
|||
| def body? | |||
| has_header?('rack.input') | |||
| has_header?(::Rack::RACK_INPUT) | |||
There was a problem hiding this comment.
ℹ️ not strictly necessary, but I always prefer to use constants when they're available
jimehk
approved these changes
Sep 12, 2024
spec/specs/apia/endpoint_spec.rb
Outdated
Comment on lines
200
to
203
| response = endpoint.execute(request) | ||
| expect(response.headers['Access-Control-Allow-Origin']).to eq 'example.com' | ||
| expect(response.headers['Access-Control-Allow-Methods']).to eq 'GET, POST' | ||
| expect(response.headers['Access-Control-Allow-Headers']).to eq 'X-Custom' |
There was a problem hiding this comment.
nitpick: Just for the sake of completeness, might as well assert that response status is 500 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix CI issues:
rack.inputis not longer set by default in mock request, so we need to always set itsuperwhen the method signature is unchanged