Skip to content
This repository has been archived by the owner on Nov 8, 2024. It is now read-only.

Do not mix internal exceptions and validation results #163

Closed
artem-zakharchenko opened this issue May 15, 2019 · 2 comments · Fixed by #178
Closed

Do not mix internal exceptions and validation results #163

artem-zakharchenko opened this issue May 15, 2019 · 2 comments · Fixed by #178

Comments

@artem-zakharchenko
Copy link
Contributor

artem-zakharchenko commented May 15, 2019

Gavel currently stores internal exceptions (such as failed parsing) in the same key as public validation results - results key of the validation result object. I strongly suggest to re-consider this behavior, and stop mixing two kinds of errors in the Gavel's output.

Why

  1. It's invalid per exceptions' design.
  2. It may lead to false testing results (such as Provides valid JSON for "body_json_example" feature gavel-spec#39)
  3. It may confuse validation results consumers, relying on validation errors, but getting internal ones
@artem-zakharchenko
Copy link
Contributor Author

I have a proposal regarding this in the next Gavel spec. Always glad to discuss it in person. Once the steady version is ready, it will be included in the next Gavel spec (see the respective v2 pull request).

@ApiaryBot
Copy link
Collaborator

🎉 This issue has been resolved in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants