Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should connectors be their in their own package? #17

Closed
fracek opened this issue Feb 7, 2022 · 3 comments
Closed

Should connectors be their in their own package? #17

fracek opened this issue Feb 7, 2022 · 3 comments

Comments

@fracek
Copy link
Contributor

fracek commented Feb 7, 2022

Web3 React distributes connectors in their own package, while wagmi comes battery included. At the time of writing there is only one connector (Argent X) so it makes sense to include it by default.

What should we do in the future when more connectors become available?

@tarrencev
Copy link
Contributor

I think doing something similar to wagmi and providing first party supported connectors and an interface for introducing new ones would be a good approach.

What do you think of providing an interface that matches this?
https://wagmi.sh/guides/connect-wallet

I'd be happy to contribute to modularizing it a bit, so we can introduce new providers without introducing breaking changes in the future.

@fracek
Copy link
Contributor Author

fracek commented Mar 10, 2022

I think that interface looks great. The main difference will be with the useConnect hook, let's not use the [{ data }, action] return value like wagmi does.

@fracek
Copy link
Contributor Author

fracek commented Mar 14, 2022

Fixed in #51

@fracek fracek closed this as completed Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants