Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source code snippet to demo pages #518

Closed
rsodre opened this issue Oct 21, 2024 · 7 comments · Fixed by #527
Closed

Add source code snippet to demo pages #518

rsodre opened this issue Oct 21, 2024 · 7 comments · Fixed by #527
Labels

Comments

@rsodre
Copy link

rsodre commented Oct 21, 2024

Each demo page should have the source code available in a tab or something.
At least a link to the demo page in the repository, so we can see how that feature works.

@ooochoche
Copy link

@rsodre please is this an open issue

@fracek
Copy link
Contributor

fracek commented Oct 23, 2024

Agree with this. We should have a link to GitHub (so that it's always up-to-date) + a description of what the demo is showing.

@fracek fracek added the bug label Oct 23, 2024
@ooochoche
Copy link

@fracek can I work on this?

@fracek
Copy link
Contributor

fracek commented Oct 29, 2024

Hey @ooochoche, yes you can work on it.

Follow the following format please:

<Brief description of the demo>

[Link to GitHub](https://github.com/apibara/starknet-react/blob/main/docs/components/demo/<demo-name>.tsx)

For example:

This demo shows how to access the currently connected account and its address.

[Link to GitHub](https://github.com/apibara/starknet-react/blob/main/docs/components/demo/account.tsx)

@ooochoche
Copy link

@fracek Thank you. I will get on it.

@ooochoche
Copy link

ooochoche commented Oct 30, 2024

@fracek I want to submit a PR now. Do I need to be assigned first?

@fracek
Copy link
Contributor

fracek commented Oct 30, 2024

You can open a PR and I will review it. No need to have the issue assigned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@rsodre @fracek @ooochoche and others