Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll down to active sidebar item on location change #26

Open
d4ncer opened this issue Jun 30, 2016 · 4 comments
Open

Scroll down to active sidebar item on location change #26

d4ncer opened this issue Jun 30, 2016 · 4 comments
Milestone

Comments

@d4ncer
Copy link
Contributor

d4ncer commented Jun 30, 2016

No description provided.

@d4ncer d4ncer added this to the beta 2 milestone Jun 30, 2016
@jackhopner
Copy link

@d4ncer How hard do you think this will be? Are we going to pull in something like https://github.com/fisshy/react-scroll or do it at the native dom layer?

@d4ncer
Copy link
Contributor Author

d4ncer commented Jul 3, 2016

@jackhopner I was thinking wrapping our sidebar in React Motion and handling all animation through there. Not sure how hard it'll be relative to the react-scroll approach, but both should be easier than a native DOM approach.

@kalmanb
Copy link
Contributor

kalmanb commented Jul 3, 2016

out of scope for now ... ?

@jackhopner
Copy link

@kalmanb I think so, we should go through the issues at some point today. It would be a nice to have and is a little funny at the moment but since our apis are small it shouldn't effect us.

@jackhopner jackhopner modified the milestone: beta 2 Aug 9, 2016
@kalmanb kalmanb added this to the later milestone Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants