Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actor ended with Actor.fail() should not be restarted #51

Open
jancurn opened this issue Oct 31, 2024 · 2 comments
Open

Actor ended with Actor.fail() should not be restarted #51

jancurn opened this issue Oct 31, 2024 · 2 comments
Assignees

Comments

@jancurn
Copy link
Member

jancurn commented Oct 31, 2024

For context, see the Exit Actor section and this conversation.

Basically, if one uses Actor.fail() to end the Actor run, we should finish the Actor run all the time and not try to restart it. Currently the SDK doesn't support this, and we should make it so - either using an API endpoint to fail the Actor (imo preferred), or some special exit code.

@mtrunkat mtrunkat assigned fnesveda and unassigned mtrunkat Nov 6, 2024
@mtrunkat
Copy link
Member

mtrunkat commented Nov 6, 2024

@B4nan , @fnesveda, could you think about this and propose a solution?

I remember that we did not want to use custom exit codes and preferred API endpoints in these cases, as the exit codes could cause problems when using some orchestrators in the future (k8s, etc.).

@jancurn
Copy link
Member Author

jancurn commented Nov 6, 2024

+1 to this, API feels cleaner, and also is probably faster than cleanup + process exit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants