Skip to content

Optimize performance by skipping unnecessary update_request() calls in RequestQueue.reclaim_request() #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vdusek opened this issue Nov 29, 2023 · 1 comment
Closed

Optimize performance by skipping unnecessary update_request() calls in RequestQueue.reclaim_request() #424

vdusek opened this issue Nov 29, 2023 · 1 comment
Labels
debt Code quality improvement or decrease of technical debt. t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@vdusek
Copy link
Collaborator

vdusek commented Nov 29, 2023 •
edited
Loading

Optimize performance by skipping unnecessary update_request() calls in RequestQueue.reclaim_request()

https://github.com/apify/apify-sdk-python/blob/v1.3.0/src/apify/storages/request_queue.py#L314:318
@vdusek vdusek added debt Code quality improvement or decrease of technical debt. t-tooling Issues with this label are in the ownership of the tooling team. labels Nov 29, 2023
@vdusek vdusek self-assigned this Nov 29, 2023
@vdusek vdusek mentioned this issue Dec 4, 2023
Merged
@vdusek vdusek removed their assignment Feb 13, 2024
@janbuchar janbuchar transferred this issue from apify/apify-sdk-python Aug 12, 2024
@vdusek vdusek changed the title Optimize performance by skipping unnecessary updateRequest() calls in RequestQueue.reclaim_request() Optimize performance by skipping unnecessary update_request() calls in RequestQueue.reclaim_request() Aug 22, 2024
@janbuchar
Copy link
Collaborator

It is almost certain that we will at least increment the retry counter for the request before calling reclaim_request, so the chances of skipping the update are slim. I'll close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
debt Code quality improvement or decrease of technical debt. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@janbuchar @vdusek