Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enqueue links by clicking for Playwright #1545

Merged
merged 3 commits into from
Sep 21, 2022

Conversation

barjin
Copy link
Contributor

@barjin barjin commented Sep 18, 2022

related: #1528

@barjin barjin force-pushed the feat/playwrightEnqueueByClicking branch from 2985999 to 8fef6d3 Compare September 19, 2022 17:55
Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to merge if its complete

btw whats the status, what helpers are missing? as part of #1550 i am making changes that will affect this part of codebase, so want to sync when to merge it - it affects mainly docs.

@barjin
Copy link
Contributor Author

barjin commented Sep 20, 2022

btw whats the status, what helpers are missing?

There are a few, mostly very easy ones:

  • Puppeteer addInterceptRequestHandler, removeInterceptRequestHandler - IMO Playwright's page.route/unroute does exactly the same thing. It's absolutely possible to write a "wrapper" here to unify the interfaces, do we want that?
  • compileScript - it's 1:1 copy, I'm not sure what is it good for, but we can have it
  • blockResources, cacheResponses - both have been made deprecated in Puppeteer utils because of cache problems. I suppose that this applies for Playwright as well. Can be replicated easily.

What is the goal here? Do we want the same interface with both libraries?

@B4nan
Copy link
Member

B4nan commented Sep 20, 2022

not sure if we need full parity here, to me this is already good enough and we can add more if someone asks for it

cc @metalwarrior665, what do you think about the deprecated ones, are they used in the wild?

@B4nan B4nan merged commit 3d25ade into master Sep 21, 2022
@B4nan B4nan deleted the feat/playwrightEnqueueByClicking branch September 21, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants