Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add utils.parseOpenGraph() #1555

Merged
merged 8 commits into from
Sep 21, 2022
Merged

feat: add utils.parseOpenGraph() #1555

merged 8 commits into from
Sep 21, 2022

Conversation

mstephen19
Copy link
Contributor

closes #1491

@mstephen19 mstephen19 changed the title feat(parseOpenGraph) feat(utils): Add parseOpenGraph util Sep 21, 2022
@mstephen19 mstephen19 requested a review from B4nan September 21, 2022 10:02
@mstephen19 @B4nan
Update packages/utils/src/internals/open_graph_parser.ts
852ca60 
Co-authored-by: Martin Adámek <banan23@gmail.com>
@mstephen19 mstephen19 requested a review from B4nan September 21, 2022 10:48
@B4nan
Copy link
Member

B4nan commented Sep 21, 2022

Maybe one last thing, what about accepting a string and parsing it automatically with cheerio in such case?

@mstephen19
Copy link
Contributor Author

@B4nan added this functionality.

@mstephen19
Copy link
Contributor Author

Sorry, had prettier enabled and it auto-saved.

@B4nan B4nan changed the title feat(utils): Add parseOpenGraph util feat: add utils.parseOpenGraph() Sep 21, 2022
@B4nan B4nan merged commit 059f85e into master Sep 21, 2022
@B4nan B4nan deleted the open-graph-parser branch September 21, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@B4nan B4nan B4nan approved these changes

@szmarczak szmarczak Awaiting requested review from szmarczak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Open Graph helper functions
2 participants
@mstephen19 @B4nan