Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade to puppeteer@19.2.0 #1623

Merged
merged 6 commits into from
Oct 31, 2022
Merged

fix: upgrade to puppeteer@19.2.0 #1623

merged 6 commits into from
Oct 31, 2022

Conversation

szmarczak
Copy link
Contributor

Fixes #1620

@szmarczak szmarczak requested a review from B4nan October 24, 2022 00:53
@B4nan
Copy link
Member

B4nan commented Oct 24, 2022

we need to wait for chrome to catch up

edit: now i see the issue saying 107 shold roll out today, good

@szmarczak szmarczak changed the title fix: upgrade to puppeteer@18.1 fix: upgrade to puppeteer@18.2.1 Oct 24, 2022
@szmarczak szmarczak changed the title fix: upgrade to puppeteer@18.2.1 fix: upgrade to puppeteer@19.2.0 Oct 27, 2022
@szmarczak
Copy link
Contributor Author

@szmarczak
Copy link
Contributor Author

szmarczak commented Oct 27, 2022

I guess the e2e tests will still fail on platform (need new builds on platform), but they should pass on local at least.

@vladfrangu
Copy link
Member

e2e tests fail across the board, but it doesn't seem related to this PR.. 😕

@szmarczak
Copy link
Contributor Author

Investigating

@szmarczak szmarczak merged commit ce36d6b into master Oct 31, 2022
@szmarczak szmarczak deleted the 181 branch October 31, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With useIncognitoPages: true, returning or error on one page crashes all pages
3 participants