fix: Correctly compute pendingRequestCount in request queue
#1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B4nan
reviewed
Jan 30, 2023
There was a problem hiding this comment.
Nice, thanks! Can we add some test or at least new assertions for this, to ensure we won't break it again?
Maybe @vladfrangu can suggest where to test it easily.
vladfrangu
approved these changes
Jan 30, 2023
If I was doing this PR I'd create a test for the pending count ( |
|
I'll merge it so we can ship it, but a PR with test would be nice :] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logic in https://github.com/apify/crawlee/blob/master/packages/memory-storage/src/resource-clients/request-queue.ts#L291-L298 is wrong. You can even see that
pendingRequestCountis being changed byhandledCountAdjustment. There are a few more cases...I fixed them and also simplified the code to be actually readable