Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshotter documentation has incorrect default value #2736

Closed
1 task
NathanSavageKaimai opened this issue Nov 4, 2024 · 0 comments
Closed
1 task

Snapshotter documentation has incorrect default value #2736

NathanSavageKaimai opened this issue Nov 4, 2024 · 0 comments
Labels
bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@NathanSavageKaimai
Copy link

Which package is this bug report for? If unsure which one to select, leave blank

@crawlee/core

Issue description

According to crawlee.dev, snapshotter considers total memory overloaded above 70% (0.7). In the actual implementation however, it only considers memory overloaded above 90%.

        const {
            eventLoopSnapshotIntervalSecs = 0.5,
            clientSnapshotIntervalSecs = 1,
            snapshotHistorySecs = 30,
            maxBlockedMillis = 50,
            maxUsedMemoryRatio = 0.9,
            maxClientErrors = 3,
            log = defaultLog,
            config = Configuration.getGlobalConfig(),
            client = config.getStorageClient(),
        } = options;

I think this has been causing me some fun and games when loading some particularly heavy webpages such as file downloads.

Code sample

NA, documentation issue

Package version

3.11

Node.js version

20

Operating system

No response

Apify platform

  • Tick me if you encountered this issue on the Apify platform

I have tested this on the next release

No response

Other context

No response

@NathanSavageKaimai NathanSavageKaimai added the bug Something isn't working. label Nov 4, 2024
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Nov 4, 2024
@B4nan B4nan closed this as completed in bab3b71 Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

No branches or pull requests

1 participant