Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-factor Buffer to work more like regular Node #96

Closed
gbrail opened this issue Dec 3, 2014 · 1 comment
Closed

re-factor Buffer to work more like regular Node #96

gbrail opened this issue Dec 3, 2014 · 1 comment

Comments

@gbrail
Copy link
Contributor

gbrail commented Dec 3, 2014

We should rely more on the standard "buffer.js" code from Node and less on custom Java code. That way it is less work to stay compatible. That means implementing "SlowBuffer" and "Buffer" just like Node 10.

@gbrail gbrail added this to the Trireme 0.8.7. milestone Sep 17, 2015
@gbrail
Copy link
Contributor Author

gbrail commented Sep 17, 2015

The solution to this problem was to continue to manage the guts of the buffer ourselves, but to use the function prototypes from the buffer.js file, with some changes so that we could do this. The result is better compatibility with all of the little checks and things that the tests require.

@gbrail gbrail closed this as completed Sep 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant