Skip to content

build(junit): limit the scope to test #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

sufyankhanrao
Copy link
Collaborator

@sufyankhanrao sufyankhanrao commented Sep 4, 2024

What

This PR limits the scope of the junit library so that the core library users don't run into version conflict issues for the testing suites.

Why

  • To avoid exposing the junit dependency outside of the library
  • To avoid running into the version conflicts

Closes #103

Type of change

Select multiple if applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause a breaking change)
  • Tests (adds or updates tests)
  • Documentation (adds or updates documentation)
  • Refactor (style improvements, performance improvements, code refactoring)
  • Revert (reverts a commit)
  • CI/Build (adds or updates a script, change in external dependencies)

Dependency Change

If a new dependency is being added, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Policy-of-adding-new-dependencies-in-the-core-libraries

Breaking change

If the PR is introducing a breaking change, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Guidelines-for-maintaining-core-libraries

Testing

List the steps that were taken to test the changes

Checklist

  • My code follows the coding conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added new unit tests

This commit limits the scope of the junit library so that the core library users don't run into version conflict issues for the testing suites.

Closes #103
@sufyankhanrao sufyankhanrao self-assigned this Sep 4, 2024
Copy link

sonarqubecloud bot commented Sep 4, 2024

@sufyankhanrao sufyankhanrao added the dependency update Used when dependency update is required. label Sep 4, 2024
@sufyankhanrao sufyankhanrao merged commit fd49f53 into main Sep 5, 2024
8 checks passed
@sufyankhanrao sufyankhanrao deleted the 103-limit-junit-library-scope branch September 5, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency update Used when dependency update is required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change JUnit dependency scope to test
2 participants