Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social media icons and link don't appear when field values are modified and updated in Branding page #3213

Closed
Nazarah opened this issue Dec 11, 2017 · 3 comments
Assignees
Labels
Milestone

Comments

@Nazarah
Copy link
Contributor

Nazarah commented Dec 11, 2017

Steps to Reproduce:

  1. go to page: https://staging.apinf.io and login as admin
  2. go to user>branding
  3. Make sure all possible social media icons and links are present (Facebook, twitter and GitHub) or add them.
  4. on the Social media section, deselect the Name field from the first social media controller and click Update
  5. (check the UI for social media icon in footer).
  6. Now minimize the controller (the 1st controller Name field was deselected) and click Update
  7. (check the UI for social media icon in footer).
  8. Repeat step 6 again.

Outcome:
On deselecting name field, the icon for that social media on footer gets broken in the UI.
On minimizing the controller, other social media icons starts to disappear or be broken.
On continuous minimization attempts, all social media icons get disappeared despite Branding page have those configured.
The icons reappear when the browser page is manually reloaded.
socialmediabranding

Expected Behavior:
If social media and their links are configured in branding page, they should appear properly in the footer, despite the above mentioned action has taken place in the associated UI.

Environment:
Windows 10, Chrome browser (latest), APInf staging site (https://staging.apinf.io)

@Nazarah Nazarah added the bug label Dec 11, 2017
@Nazarah
Copy link
Contributor Author

Nazarah commented Dec 11, 2017

The issue was identified in release 0.52 in staging and was verified in nightly apinf.

@marla-singer
Copy link
Contributor

@Nazarah I think it would better to change UI for social media block and have the same UI as we have for Organization Social Media links. What do you think?
joxi_screenshot_1513083256566

@Nazarah
Copy link
Contributor Author

Nazarah commented Dec 13, 2017

@marla-singer go for it.

@ghost ghost removed the in progress label Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants