Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration 12 does not remove old social media links #3333

Closed
matleppa opened this issue Jan 16, 2018 · 2 comments
Closed

Migration 12 does not remove old social media links #3333

matleppa opened this issue Jan 16, 2018 · 2 comments
Assignees

Comments

@matleppa
Copy link
Member

matleppa commented Jan 16, 2018

Description

In Branding DB the Social media link structure was changed with PR 3222.

Previously social media links were stored into an array.
After change there is a social media object containing named parameters for links.

Migration fills new structure by converting old links.

Problem

Migration is not removing old array of social media links after conversion, thus it remains.
Unnecessary old structure of social media links should be removed.

@matleppa matleppa self-assigned this Jan 16, 2018
@marla-singer
Copy link
Contributor

Migration is not removing old array of social media links after conversion, thus it remains.
Unnecessary old structure of social media links should be removed.

Can't agree on this point. During migration, it doesn't recommend to remove old data because it needs to keep persistent, consistent data and keep a possibility to roll back between releases, for instance

@apinf/developers Please add comment as well

@matleppa
Copy link
Member Author

Closed as unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants