-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rubocop is under heavy development, but dependency is locked #144
Comments
Proposed new text for the Caveats in the README:
Things that don't make sense to me:
|
Yeah, I don't make releases terribly often, so if you want to use this having an old RuboCop is a danger. Sadly, your ability to lock RuboCop in your local project doesn't affect what's in the Docker image I publish, and I don't want to accidentally get RuboCop updates outside of major version updates in the Docker image. You'll need to solve that problem before RuboCop can float in the gemspec, as well as figure out how to communicate the RuboCop <-> Docker image version mapping to users. |
Another practical matter here is that pronto-rubocop is awaiting a release that will support Rubocop >=1: |
@apiology It isn't clear to me why there is a mention of docker. I saw this as being a Rubygem, that I would install in my project for code analysis. It seems there is a docker use case that isn't my use case, so perhaps that isn't the only use case? |
That's correct; there's a Docker image also published here. Happy to answer questions you have about it; the general goal of it is to provide an alternative way to run this that avoids the pain of installing multiple tools in particular versions, and it's something I use quite a bit in places like CI. There's a CircleCI orb (plugin) here, for instance. The solution to allow users to update freely in their gem is probably to create a separate constraint in the Dockerfile so that the constraint doesn't need to be put in the gemspec (contributions towards this direction probably welcome). An update on the above on the Pronto-related constraint - they recently made a release, which may allow for a more aggressive update here in general if they continue on and also loosen the < 1.0 constraint, which didn't make the release. Also be aware that that I'm looking at moving my use of the functionality of this gem to some other already-generally-supported framework that has drivers for multiple existing tools (e.g. Pronto/Overcommit/etc). Potentially that may include a quality metric violation ratcheting behavior as well - stay tuned! |
pronto-rubocop 0.11.1 has been released, which supports RuboCop >= 1.0 |
This gem locks the rubocop dependency to
~> 0.78.0
, which prevents using more recent releases of Rubocop (current is0.82.0
, and there are a bunch of fixes in head about to be released as well).The bug fix list between
0.78.0
and0.82.0
is quite huge:https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md
Is there a reason the dependency lock is so strict here?
The text was updated successfully, but these errors were encountered: