Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter links are compiled incorrectly if the course has a subdirectory above the module directories #146

Open
markkuriekkinen opened this issue Jun 1, 2022 · 0 comments
Assignees
Labels
effort: days Solving this issue could take days. Starting with the creation of a new branch to the merging experience: moderate required knowledge estimate requester: Aalto teacher The issue is raised by a teacher from Aalto University type: bug This is a bug which is critical for the correct operation of the system

Comments

@markkuriekkinen
Copy link
Contributor

Course directory structure:

mycourse/
|-- _content
   |-- module01
   |-- module02

Usually, the module directories are directly in the root of the course repository.

Links from chapter to another chapter are broken in the above course structure.

  • This regular expression does not match the chapter file path:
    if q2 and q2.search(val_path_from_root):
  • The regex is defined here:
    q2 = re.compile(r'^(' + '|'.join(chapter_dirs) + r')(/|\\)') # Starts with a module directory name.
  • The regex requires that the module directory is right under the course root (note the ^).
  • In addition, the regex uses incorrect module directory names. The names contain the parent directory too in the form _content_module01. That does not match real file paths.
@markkuriekkinen markkuriekkinen added type: bug This is a bug which is critical for the correct operation of the system experience: moderate required knowledge estimate requester: Aalto teacher The issue is raised by a teacher from Aalto University effort: days Solving this issue could take days. Starting with the creation of a new branch to the merging labels Jun 1, 2022
@markkuriekkinen markkuriekkinen self-assigned this Jun 1, 2022
@markkuriekkinen markkuriekkinen moved this to In Progress in A+ sprints Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: days Solving this issue could take days. Starting with the creation of a new branch to the merging experience: moderate required knowledge estimate requester: Aalto teacher The issue is raised by a teacher from Aalto University type: bug This is a bug which is critical for the correct operation of the system
Projects
Status: In Progress
Development

No branches or pull requests

1 participant