Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility issue with hidden block #152

Open
etanttila opened this issue Aug 18, 2022 · 1 comment
Open

Accessibility issue with hidden block #152

etanttila opened this issue Aug 18, 2022 · 1 comment
Labels
area: accessibility effort: hours The issue seems to be small and should be doable in hours or few days. experience: good first issue Good for newcomers requester: Aalto teacher The issue is raised by a teacher from Aalto University status: requires a priority Currently using this label to flag issues that need EDIT decision ASAP (even if there was priority) type: bug This is a bug which is critical for the correct operation of the system

Comments

@etanttila
Copy link

The hidden block -component is hidden/displayed by pressing a link, which behaves like a button (changes the content on the page). This probably is an accessibility issue (see A+ accessibility audit).

Also, it might be good that the default text (Show/Hide) would have also a Finnish translation when used in Finnish materials. (This is not absolutely necessary, as it can be overridden with the :label: option.)
@markkuriekkinen
Copy link
Contributor

True, a link should take the user to another html page, while a button could modify/reveal content in the current page. That link should be changed to a button.

@markkuriekkinen markkuriekkinen added type: bug This is a bug which is critical for the correct operation of the system experience: good first issue Good for newcomers effort: hours The issue seems to be small and should be doable in hours or few days. requester: Aalto teacher The issue is raised by a teacher from Aalto University area: accessibility status: requires a priority Currently using this label to flag issues that need EDIT decision ASAP (even if there was priority) labels Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: accessibility effort: hours The issue seems to be small and should be doable in hours or few days. experience: good first issue Good for newcomers requester: Aalto teacher The issue is raised by a teacher from Aalto University status: requires a priority Currently using this label to flag issues that need EDIT decision ASAP (even if there was priority) type: bug This is a bug which is critical for the correct operation of the system
Projects
A+ sprints
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markkuriekkinen @etanttila