Length option in freetext questions (in questionnaires) does not affect anything

[markkuriekkinen]

The length option has been available for freetext questions for a very long time, but it actually does not do anything. There is code that tries to use them, but it looks like the intended HTML attributes are not saved to the exercise yaml file. Since the yaml file does not contain anything about the length, of course the MOOC-Grader can not render any HTML for the corresponding HTML size attribute.

a-plus-rst-tools/directives/questionnaire.py

Lines 619 to 634 in 40c904b

	if self.height > 1:
	attrs = {
	'rows': self.height,
	'class': self.position,
	}
	if self.length:
	attrs['cols'] = self.length
	element = aplus_nodes.html('textarea', attrs)
	else:
	attrs = {
	'type': 'text',
	'class': self.position,
	}
	if self.length:
	attrs['size'] = self.length
	element = aplus_nodes.html('input', attrs)

The node constructor:

a-plus-rst-tools/aplus_nodes.py

Line 26 in 40c904b

def __init__(self, tagname, attributes={}, no_write=False, skip_html=False, *children, **other_attributes):

MOOC-Grader renders questionnaires here:

• https://github.com/apluslms/mooc-grader/blob/master/access/types/forms.py
• https://github.com/apluslms/mooc-grader/blob/master/access/templates/access/graded_form.html
• https://github.com/apluslms/mooc-grader/blob/master/access/templates/access/graded_form_feedback.html

The Aplus manual includes instructions for using length even though it does not work.

• apluslms/aplus-manual@62c6632
• https://github.com/apluslms/aplus-manual/blob/master/questionnaires/questionnaires.rst#freetext-questions