Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting one garbage character from container.exec() #736

Open
jamesmurdza opened this issue Jun 10, 2023 · 5 comments
Open

Getting one garbage character from container.exec() #736

jamesmurdza opened this issue Jun 10, 2023 · 5 comments

Comments

@jamesmurdza
Copy link

I've written two helper functions using Dockerode. The idea is to run a command synchronously and then return the results as a string.

It works well, except each chunk that is returned by stream.on('data') starts with a garbage character, like "X", "*", "!", etc. I can't figure out why.

This happens for multiple commands, such as "bash" and "cat".

Help is much appreciated!

My code below:

async function waitForStreamEnd(stream: NodeJS.ReadableStream): Promise<void> {
  return new Promise<void>((resolve, reject) => {
    try {
      stream.on('end', async () => {
        resolve();
      });
    } catch (err) {
      reject(err);
    }
  });
}

async function runCommandInContainer(container: Docker.Container, command: string[]): Promise<string> {
  const exec = await container.exec({
    Cmd: command,
    AttachStdout: true,
    AttachStderr: true,
  });
  const stream = await exec.start({ hijack: true, stdin: true });
  let output = "";
  stream.on('data', (data) => {
    output += data;
  });
  await waitForStreamEnd(stream);
  return output;
}
@jamesmurdza jamesmurdza changed the title Getting one garbage character Getting one garbage character in stdout Jun 10, 2023
@jamesmurdza jamesmurdza changed the title Getting one garbage character in stdout Getting one garbage character from container.exec() Jun 10, 2023
@Akimyou
Copy link

Akimyou commented Jun 29, 2023

const readStream = (stream: stream.Duplex) => {
  let output: string = "";
  return new Promise<string>((resolve, reject) => {
    stream.on("data", (chunk: string) => {
      output += chunk;
    });

    stream.on("end", () => {
     // handle garbage
      resolve(output.trim().split("\n").map(processString).join("\n"));
    });
  });
  
  function processString(str: string): string {
    const out = Buffer.from(str, "binary");
    if (out.readUInt8(0) === 1) {
      return out.toString("utf8", 8);
    } else {
      return out.toString("utf8", 0);
    }
  }
};

May be this function can help you.

@jamesmurdza
Copy link
Author

Interesting, I will try this. Any explanation why this would work?

@Fhwang0926
Copy link

add more comment
i also has it issue but i guess it is docker' api problem, is not?

for example, exec with ping

image

i just console.log of exec result

@jamesmurdza
Copy link
Author

@Fhwang0926 Were you able to figure out any solution?

@ewanmellor
Copy link

When you do not use the tty flag, Docker sends data with the first four bytes set to tell you whether the data is from stdout or stderr, and its length. This is the "garbage" that you're seeing at the start of the line.

See "Stream format" within https://docs.docker.com/reference/api/engine/version/v1.43/#tag/Container/operation/ContainerAttach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants