New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing option type `force: boolean` from `volume.remove()` #772

Open

pablomendezroyo opened this issue Jul 5, 2024 · 1 comment

Labels

pablomendezroyo commented Jul 5, 2024

Missing option type force: boolean from volume.remove():

src code: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/3c78f0fd3c1bd7c16bde2b58e3dccadfccbdb0f1/types/dockerode/index.d.ts#L474
Docker volumes delete API endpoint: https://docs.docker.com/engine/api/v1.46/#tag/Volume/operation/VolumeDelete

The text was updated successfully, but these errors were encountered:

Owner

apocas commented Jul 10, 2024

Dockerode accepts options in volume.remove() check: https://github.com/apocas/dockerode/blob/master/lib/volume.js#L57

I don't do typescript so not sure whats happening there :)

apocas added the external label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment