Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show original mapper name as well as their current name #55

Open
mzhang28 opened this issue Mar 4, 2023 · 1 comment
Open

Show original mapper name as well as their current name #55

mzhang28 opened this issue Mar 4, 2023 · 1 comment
Labels

Comments

@mzhang28
Copy link
Contributor

mzhang28 commented Mar 4, 2023

In maps like Sakura no Uta, the mapper is banned so there's nothing fetched
from the osu API. It looks odd to have nothing there.

I think the original mapper name (when the map was ranked) should show up there,
and their current name should only appear under it in smaller text or something.

Or we could just mitigate this one particular case of banned mapper, by just
showing the original name if their current can't be found.

@apollo-dw
Copy link
Owner

Not opposed to this. I can picture this maybe being a setting depending on which one the user prefers, and then banned mapper maps will always point to the map-based username. I wonder how this will play into guest difficulty displays tho 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants