config service(version 2.0.0-RC1 or above) return 404 when use double slash "//" in http path

[Anilople]

• I have checked the discussions
• I have searched the issues of this repository and believe that this is not a duplicate.
• I have checked the FAQ of this repository and believe that this is not a duplicate.

Describe the bug

apollo client read config fail when there is a slash in the suffix of apollo.meta, for example

apollo.meta=http://ip:port/

but it work well when / doesn't occur in the suffix. i.e

apollo.meta=http://ip:port

Reproduce

run

curl http://localhost:8080//services/config

to access config service, version 2.0.0-RC1

get

{"timestamp":"2023-08-01T21:49:31.123+0800","status":404,"error":"Not Found","path":"//services/config"}

watch out that // after port 8080

Expected behavior

get json like

[{"appName":"APOLLO-CONFIGSERVICE","instanceId":"localhost:apollo-configservice:8080","homepageUrl":"http://172.29.234.239:8080/"}]

Additional Details & Logs

• Platform and Operating System

$ java -version
openjdk version "1.8.0_362"
OpenJDK Runtime Environment (build 1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09)
OpenJDK 64-Bit Server VM (build 25.362-b09, mixed mode)

• Version 2.0.0-RC1 or above

config service's version	double slash "//" work or not
1.8.2	work well
1.9.2	work well
2.0.0-RC1	404
2.0.1	404

more detail from version 1.8.2 to 2.0.1

1.8.2

curl http://localhost:8080/services/config

[{"appName":"APOLLO-CONFIGSERVICE","instanceId":"localhost:apollo-configservice:8080","homepageUrl":"http://172.29.234.239:8080/"}]

curl http://localhost:8080//services/config

[{"appName":"APOLLO-CONFIGSERVICE","instanceId":"localhost:apollo-configservice:8080","homepageUrl":"http://172.29.234.239:8080/"}]

1.9.2

curl http://localhost:8080/services/config

[{"appName":"APOLLO-CONFIGSERVICE","instanceId":"localhost:apollo-configservice:8080","homepageUrl":"http://172.29.234.239:8080/"}]

curl http://localhost:8080//services/config

[{"appName":"APOLLO-CONFIGSERVICE","instanceId":"localhost:apollo-configservice:8080","homepageUrl":"http://172.29.234.239:8080/"}]

2.0.0-RC1

curl http://localhost:8080/services/config

[{"appName":"APOLLO-CONFIGSERVICE","instanceId":"localhost:apollo-configservice:8080","homepageUrl":"http://172.29.234.239:8080/"}]

curl http://localhost:8080//services/config

{"timestamp":"2023-08-01T21:54:25.152+0800","status":404,"error":"Not Found","path":"//services/config"}

2.0.1

curl http://localhost:8080/services/config

[{"appName":"APOLLO-CONFIGSERVICE","instanceId":"localhost:apollo-configservice:8080","homepageUrl":"http://172.29.234.239:8080/"}]

curl http://localhost:8080//services/config

{"timestamp":"2023-08-01T21:49:31.123+0800","status":404,"error":"Not Found","path":"//services/config"}

trouble shoot

apollo-client

https://github.com/apolloconfig/apollo-java/blob/265fe49ddf0a4becad40ecf5bcd6bd1c86d9826b/apollo-client/src/main/java/com/ctrip/framework/apollo/internals/ConfigServiceLocator.java#L248C26-L248C35

    return domainName + "/services/config?" + MAP_JOINER.join(queryParams);

when domainName(apollo.meta) is http://ip:port/ will get double slash // in http://ip:port//services/config?...

config-service

The path mapping in

apollo/apollo-configservice/src/main/java/com/ctrip/framework/apollo/metaservice/controller/ServiceController.java

Line 48 in 99b76dc

public List<ServiceDTO> getConfigService(

Guess that when Spring MVC or Spring WebFlux update in #4295 cause it?

I.e '//' cannot access again.

---

solution:

• apollo-client: delete the suffix '/' of apollo.meta on then runtime?
• config service: keep the compability? For example add a servlet filter when meet '//' then convert it to '/'

[Anilople]

According to https://stackoverflow.com/questions/70606716/getting-404-error-when-url-contains-double-slash-after-spring-boot-2-5-to-2-6-mi

Just add a property in config service's .properties file

spring.mvc.pathmatch.matching-strategy=ant-path-matcher

Everything is great again!

---

Reference:

• https://docs.spring.io/spring-boot/docs/2.7.14/reference/html/web.html#web.servlet.spring-mvc.content-negotiation
• https://github.com/spring-projects/spring-boot/blob/191ac10009cdf1f0663221dad16993493ca50205/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/servlet/WebMvcProperties.java#L103

[nobodyiam]

The release notes for Spring Boot 2.6 include a section titled PathPattern Based Path Matching Strategy for Spring MVC. This particular change seems to have escaped my attention when issue #4295 was raised. To maintain the original logic, should we set the following configuration as the default?

spring.mvc.pathmatch.matching-strategy=ant-path-matcher

[stale]

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically closed because it has not had activity in the last 7 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted". Thank you for your contributions.