use checkDocument instead of verifyDocumentType

Author: phryneas

src/__tests__/__snapshots__/exports.ts.snap

@@ -461,7 +461,6 @@ Array [
   "stringifyForDisplay",
   "stripTypename",
   "valueToObjectRepresentation",
-  "verifyDocumentType",
   "wrapPromiseWithState",
 ]
 `;

src/core/ApolloClient.ts

@@ -891,7 +891,6 @@ export class ApolloClient implements DataProxy {
    * ```json
    *{
    *  limits:     {
-   *    parser: 1000,
    *    canonicalStringify: 1000,
    *    print: 2000,
    *    'documentTransform.cache': 2000,
@@ -907,7 +906,6 @@ export class ApolloClient implements DataProxy {
    *    'inMemoryCache.executeSubSelectedArray': 5000
    *  },
    *  sizes: {
-   *    parser: 26,
    *    canonicalStringify: 4,
    *    print: 14,
    *    addTypenameDocumentTransform: [

src/core/QueryManager.ts

@@ -33,7 +33,11 @@ import { execute } from "@apollo/client/link/core";
 import type { MaybeMasked, Unmasked } from "@apollo/client/masking";
 import { maskFragment, maskOperation } from "@apollo/client/masking";
 import type { DeepPartial } from "@apollo/client/utilities";
-import { print, verifyDocumentType } from "@apollo/client/utilities";
+import {
+  checkDocument,
+  print,
+  verifyDocumentType,
+} from "@apollo/client/utilities";
 import { AutoCleanedWeakCache, cacheSizes } from "@apollo/client/utilities";
 import {
   addNonReactiveToNamedFragments,
@@ -274,7 +278,7 @@ export class QueryManager {
       "mutation option is required. You must specify your GraphQL document in the mutation option."
     );
 
-    verifyDocumentType(mutation, OperationTypeNode.MUTATION);
+    checkDocument(mutation, OperationTypeNode.MUTATION);
 
     invariant(
       fetchPolicy === "network-only" || fetchPolicy === "no-cache",
@@ -788,7 +792,7 @@ export class QueryManager {
     T,
     TVariables extends OperationVariables = OperationVariables,
   >(options: WatchQueryOptions<TVariables, T>): ObservableQuery<T, TVariables> {
-    verifyDocumentType(options.query, OperationTypeNode.QUERY);
+    checkDocument(options.query, OperationTypeNode.QUERY);
 
     const query = this.transform(options.query);
 
@@ -826,7 +830,7 @@ export class QueryManager {
     options: QueryOptions<TVars, TData>,
     queryId = this.generateQueryId()
   ): Promise<QueryResult<MaybeMasked<TData>>> {
-    verifyDocumentType(options.query, OperationTypeNode.QUERY);
+    checkDocument(options.query, OperationTypeNode.QUERY);
 
     const query = this.transform(options.query);
 
@@ -1031,7 +1035,7 @@ export class QueryManager {
       extensions = {},
     } = options;
 
-    verifyDocumentType(query, OperationTypeNode.SUBSCRIPTION);
+    checkDocument(query, OperationTypeNode.SUBSCRIPTION);
 
     query = this.transform(query);
     variables = this.getVariables(query, variables);

src/react/hooks/__tests__/useSuspenseQuery.test.tsx

@@ -374,7 +374,7 @@ describe("useSuspenseQuery", () => {
       });
     }).toThrowError(
       new InvariantError(
-        "Running a Query requires a graphql Query, but a Mutation was used instead."
+        "Running a query requires a graphql query, but a mutation was used instead."
       )
     );
   });

src/utilities/caching/__tests__/getMemoryInternals.ts

@@ -10,8 +10,6 @@ import {
 } from "@apollo/client/core";
 import { createPersistedQueryLink } from "@apollo/client/link/persisted-queries";
 import { removeTypenameFromVariables } from "@apollo/client/link/remove-typename";
-// importing react so the `parser` cache initializes
-import "@apollo/client/react";
 import { cacheSizes } from "@apollo/client/utilities";
 
 // this is compiled away so we need to import it from sources
@@ -69,7 +67,6 @@ it("returns information about cache usage (empty caches)", () => {
   expect(client.getMemoryInternals?.()).toEqual({
     limits: defaultCacheSizesAsObject,
     sizes: {
-      parser: 0,
       canonicalStringify: 0,
       print: 0,
       addTypenameDocumentTransform: [
@@ -148,7 +145,6 @@ it("returns information about cache usage (some query triggered)", () => {
   expect(client.getMemoryInternals?.()).toStrictEqual({
     limits: defaultCacheSizesAsObject,
     sizes: {
-      parser: 0,
       canonicalStringify: 0,
       print: 1,
       addTypenameDocumentTransform: [

src/utilities/graphql/__tests__/verifyDocumentType.test.ts

@@ -2,6 +2,7 @@ import type {
   DocumentNode,
   FragmentDefinitionNode,
   OperationDefinitionNode,
+  OperationTypeNode,
   ValueNode,
 } from "graphql";
 
@@ -17,7 +18,10 @@ type OperationDefinitionWithName = OperationDefinitionNode & {
 };
 
 // Checks the document for errors and throws an exception if there is an error.
-export function checkDocument(doc: DocumentNode) {
+export function checkDocument(
+  doc: DocumentNode,
+  expectedType?: OperationTypeNode
+) {
   invariant(
     doc && doc.kind === "Document",
     `Expecting a parsed GraphQL document. Perhaps you need to wrap the query \
@@ -42,6 +46,16 @@ string in a "gql" tag? http://docs.apollostack.com/apollo-client/core.html#gql`
     operations.length
   );
 
+  if (expectedType) {
+    invariant(
+      operations.length == 1 && operations[0].operation === expectedType,
+      `Running a %s requires a graphql ` + `%s, but a %s was used instead.`,
+      expectedType,
+      expectedType,
+      operations[0].operation
+    );
+  }
+
   return doc;
 }
 

src/utilities/graphql/getFromAST.ts

@@ -91,8 +91,6 @@ export {
   isSubscriptionOperation,
 } from "./graphql/operations.js";
 
-export { verifyDocumentType } from "./graphql/verifyDocumentType.js";
-
 export {
   concatPagination,
   offsetLimitPagination,

src/utilities/graphql/verifyDocumentType.ts

@@ -137,7 +137,6 @@ function _getApolloClientMemoryInternals(this: ApolloClient) {
     limits: getCurrentCacheSizes(),
     sizes: {
       print: globalCaches.print?.(),
-      parser: globalCaches.parser?.(),
       canonicalStringify: globalCaches.canonicalStringify?.(),
       links: linkInfo(this.link),
       queryManager: {