Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Local Resolvers documentation wording #10210

Closed
bignimbus opened this issue Oct 19, 2022 · 0 comments · Fixed by #10211
Closed

Update Local Resolvers documentation wording #10210

bignimbus opened this issue Oct 19, 2022 · 0 comments · Fixed by #10211
Assignees

Comments

@bignimbus
Copy link
Contributor

bignimbus commented Oct 19, 2022

Context:

When #10060 is closed, Local Resolver functionality will still be supported by the Apollo team, albeit in a different form. We updated the Local Resolvers documentation recently to reflect our plans for Local Resolvers. A few suggestions for further updates:

  • Remove (deprecated) from the heading
  • Edit the ⚠️ DEPRECATION WARNING section as follows:
    • Replace ⚠️ DEPRECATION WARNING with NOTE
    • Current wording could be interpreted that we might remove Local Resolvers from Apollo Client before we ship an analogous ApolloLink implementation. New wording should make it clear that we plan to continue to support Local Resolver functionality continuously without a gap between removing it from core and adding a new implementation
@bignimbus bignimbus self-assigned this Oct 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant