You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have a lot of large read-only queries that I am using fetchPolicy='no-cache', but through the vue-apollo bindings the getCurrentQueryResult function is used in certain contexts that do a lot of unnecessary work / exceptions being thrown and caught that show up in my profiling analysis.
At this line, it should be safe to no execute this.dataStore.getCache().read(...) if observableQuery.options.fetchPolicy = 'no-cache' since our store will never contain this query.
Probably short-circuiting the function and returning: return maybeDeepFreeze({ data: {}, partial: true }); would be best.
To help provide a more clear separation between feature requests / discussions and bugs, and to help clean up the feature request / discussion backlog, Apollo Client feature requests / discussions are now being managed under the https://github.com/apollographql/apollo-feature-requests repository.
I have a lot of large read-only queries that I am using fetchPolicy='no-cache', but through the vue-apollo bindings the getCurrentQueryResult function is used in certain contexts that do a lot of unnecessary work / exceptions being thrown and caught that show up in my profiling analysis.
At this line, it should be safe to no execute this.dataStore.getCache().read(...) if
observableQuery.options.fetchPolicy = 'no-cache'
since our store will never contain this query.Probably short-circuiting the function and returning:
return maybeDeepFreeze({ data: {}, partial: true });
would be best.apollo-client/packages/apollo-client/src/core/QueryManager.ts
Line 976 in 9ac90e0
The text was updated successfully, but these errors were encountered: