Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions within updateQueries reducer are swallowed silently #479

Closed
stretchkennedy opened this issue Jul 29, 2016 · 1 comment
Closed
Assignees

Comments

@stretchkennedy
Copy link

At https://github.com/apollostack/apollo-client/blob/master/src/QueryManager.ts#L261 all errors are caught and turned into APOLLO_MUTATION_ERROR actions, which aren't logged by the crashReporter or by anything else, but are passed through to the wrapped component. This includes errors from collectResultBehaviorsFromUpdateQueries and thus from updateQueries, making it hard to tell when a reducer is broken.

I was going to create a pull request, but I'm not sure where or how these errors should be logged.

@stubailo
Copy link
Contributor

stubailo commented Aug 3, 2016

Merged a PR to log them using console.error. If we come up with a better way, I'd be happy to do it as well.

@stubailo stubailo closed this as completed Aug 3, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants