Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query component does not clear error after success #4988

Closed
joepuzzo opened this issue Jun 20, 2019 · 3 comments
Closed

Query component does not clear error after success #4988

joepuzzo opened this issue Jun 20, 2019 · 3 comments

Comments

@joepuzzo
Copy link

This still seems to be an issue apollographql/react-apollo#2658 Using "apollo-client": "^2.6.3", and "react-apollo": "^2.5.5"

@joepuzzo
Copy link
Author

joepuzzo commented Jun 20, 2019

I have tried executing client.watchQuery manually as well to see what next() gets called with and even when chromes network tab clearly shows that the new request had no errors next() gets called with a result that contains the old errors.

To reproduce simply call client.watchQuery then subscribe and log the result from the next() function. This happens when the first request fails do to a graphql error and then the second succeeds.

@casprwang
Copy link

casprwang commented Jul 1, 2019

I ran into the same issue from apollo-client@2.5.8. I also noticed the error got cleared once and then came back.

@hwillson
Copy link
Member

Please try a recent version of @apollo/client and let us know if this issue is still happening. Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants