Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate apollo-upload-client in @apollo/client package #6671

Closed
saadaouad opened this issue Jul 22, 2020 · 4 comments
Closed

Integrate apollo-upload-client in @apollo/client package #6671

saadaouad opened this issue Jul 22, 2020 · 4 comments

Comments

@saadaouad
Copy link

I'd like to know if it's possible to integrate apollo-upload-client in @apollo/client package?

@benjamn
Copy link
Member

benjamn commented Jul 22, 2020

I really don't think this is something the maintainers of apollo-upload-client would want, since it would tie their release schedule and versioning to that of @apollo/client, and require PRs against this repo to make any changes. Additionally, the Apollo Client core team is just three people, so we don't currently have bandwidth to support more @apollo/client/* sub-packages than we already do. The @apollo/client/react/* and @apollo/client/link/* packages are already pushing it (though I appreciate your implied confidence in our abilities!). I think we need to let the dust settle on those (see #6656) before we consider adding any more.

@mschipperheyn
Copy link

mschipperheyn commented Jul 23, 2020

Also, this may add packages size for people who might not even use it. I would personally recommend avoiding server uploads and instead use direct to S3 / Azure style uploads using your server only as an intermediary to get an upload token. So you can upload directly and not deal with all the challenges associated with processing upload streams. And your Graphql can just provide you with a standard mutation to get the upload token.

@benjamn benjamn closed this as completed Jul 24, 2020
@saadaouad
Copy link
Author

I really don't think this is something the maintainers of apollo-upload-client would want, since it would tie their release schedule and versioning to that of @apollo/client, and require PRs against this repo to make any changes. Additionally, the Apollo Client core team is just three people, so we don't currently have bandwidth to support more @apollo/client/* sub-packages than we already do. The @apollo/client/react/* and @apollo/client/link/* packages are already pushing it (though I appreciate your implied confidence in our abilities!). I think we need to let the dust settle on those (see #6656) before we consider adding any more.

I see what do you mean @benjamn.
To be honest I think it would be great to handle multipart/form-data request sending using @apollo/client in the future... happy to help on that.

@acomito
Copy link

acomito commented Sep 30, 2020

Also bummed out to hear we can't handle files in 3.0...

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants