-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DevTools failed to load SourceMap from @apollo/client #6921
Comments
The fix for this is easy - just include typescript sources in package.json EDIT: I see now that tsc outputs to |
@bennypowers Do you mean to include the files in the apollo-client package.json and repackage the apollo-client or in our own package.json? |
@ryan-zheng-teki yes, I'm suggesting to ship the typescript source files in the npm package tarball, or alternatively, to ship inline source map comments. edit: what I mean is that |
I thougt I'd try this out: main...Billy-:fix-ts-sourcemaps But unfortunately getting a lot of typescript errors in my build when I used the linked package.. 🙁 Webpack / TypeScript Error Details
|
@Billy- do you exclude |
Yes, I have
in my tsconfig |
I have made a minimal reproduction in a repo: https://github.com/Billy-/apollo-client-test This also includes another problem, which I am going to create an issue for soon.
|
Check this reply ----> #6651 |
@silnose that will quiet the warnings in Chrome but doesn't solve the issue. For instance I'm getting these warnings in Webpack builds. The problem seems to be that the sourceMap graph is pointing to locations that simply don't exist. Probably a mismatch between the src file structure and the build file structure as @bennypowers suggested. |
I have the same problem with Apollo Angular, so this doesn't seem to be related to React:
|
Any solutions to this yet? |
I have the same problem after just updating to Angular v11 when running
|
Let us know if this is still a concern with |
@hwillson I am on
I have update my minimal repro repo and it's reflected there too: https://github.com/Billy-/apollo-client-test/runs/2883996403?check_suite_focus=true |
Hi @hwillson , I'm encountering the same as @Billy-
|
@Billy- @erichiller Since the problem seems to be coming from |
@benjamn - That fixed it! Thanks for letting me know . |
@richardscarrott Apollo Client doesn't use webpack for any part of our build, so I don't think we're responsible for those |
@richardscarrott I am having the same issue, any luck figuring this out? |
Intended outcome:
I just added the apollo/client to my Webpack/TS/React project and now I have a tons of warnings in my devtools.
I can use some hack to ignore them, but you might wants to know about this inconvenience.
I also added 'source-map-loader', and now warnings had change:
Actual outcome:
There is not any warnings.
How to reproduce the issue:
Just import apollo/client and run a project with webpack. I use webpack@4
Versions
npx envinfo@latest --preset apollo --clipboard
The text was updated successfully, but these errors were encountered: