Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apollo Client Devtools conflicts with es6-module-loader js #7845

Closed
kingstonfung opened this issue Mar 15, 2021 · 1 comment · Fixed by #7846
Closed

Apollo Client Devtools conflicts with es6-module-loader js #7845

kingstonfung opened this issue Mar 15, 2021 · 1 comment · Fixed by #7846
Assignees

Comments

@kingstonfung
Copy link

Intended outcome:
The plugin shouldn't interfere with, or blocking the site's JS

Actual outcome:
I see a JS error complaint saying process.platform is undefined, therefore .match() is unavailable

Screen Shot 2021-03-15 at 10 32 34 AM

How to reproduce the issue:

  1. Include / embed the ES6 Modules JS to your html page (along with a sample React + Apollo project to ensure Devtools will be triggered and turned on)
  2. At the end of the JS, try to render something on the DOM such as document.body.innerHTML += "HELLO WORLD";
  3. With Apollo Client Devtools enabled, open up this project
  4. Console should indicate an error saying Cannot read property 'match' of undefined and you should not be able to see HELLO WORLD.
  5. If you turn off the plugin, everything works fine

Versions
Apollo Client Devtools 3.0.0
https://chrome.google.com/webstore/detail/apollo-client-devtools/jdkknkkbebbapilgoeccciglkfbmbnfm

Prior to Devtools 3.0.0, my project worked fine without issues with Apollo Client Devtools.

If more info are needed, or if the team decides this module is simply too old to support (understandable), please just let me know! Thanks very much.

@hwillson
Copy link
Member

Thanks @kingstonfung - we're looking into this (and tracking things in apollographql/apollo-client-devtools#455).

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants