Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Faster replacement for fast-json-stable-stringify #8185

Closed
hwillson opened this issue May 10, 2021 · 1 comment · Fixed by #8222
Closed

Feature: Faster replacement for fast-json-stable-stringify #8185

hwillson opened this issue May 10, 2021 · 1 comment · Fixed by #8222
Assignees
@benjamn
Labels
🎄 dependencies ✔ confirmed 🧞‍♂️ enhancement 🛬 fixed-in-prerelease 🐎 performance 👩‍🏭 refactor

Comments

@hwillson
Copy link
Member

We have worked out a faster method of handling the fast-json-stable-stringify functionality Apollo Client currently relies on internally. This issue tracks the replacement of fast-json-stable-stringify.
@hwillson hwillson added this to the Release 4.0 milestone May 10, 2021
@benjamn benjamn mentioned this issue May 14, 2021
Merged
@hwillson hwillson modified the milestones: Release 4.0, Release 3.4 May 18, 2021
@benjamn benjamn linked a pull request May 18, 2021 that will close this issue
Remove dependency on fast-json-stable-stringify #8222
Merged
@benjamn
Copy link
Member

benjamn commented May 18, 2021

Fixed by #8222!

@benjamn benjamn closed this as completed May 18, 2021
@hwillson hwillson removed this from the MM-2021-06 milestone Jul 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@benjamn benjamn

Labels
🎄 dependencies ✔ confirmed 🧞‍♂️ enhancement 🛬 fixed-in-prerelease 🐎 performance 👩‍🏭 refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove dependency on fast-json-stable-stringify apollographql/apollo-client
2 participants
@benjamn @hwillson