Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@defer label validation #3187

Closed
Tracked by #3093
calvincestari opened this issue Aug 10, 2023 · 1 comment · Fixed by apollographql/apollo-ios-dev#28
Closed
Tracked by #3093

@defer label validation #3187

calvincestari opened this issue Aug 10, 2023 · 1 comment · Fixed by apollographql/apollo-ios-dev#28
Assignees
@calvincestari
Milestone
`@defer` support

Comments

@calvincestari
Copy link
Member

calvincestari commented Aug 10, 2023 •
edited
Loading

We will require @defer directives to have an accompanying label: argument. This is needed to provide naming of the generated fragment and for identifying incremental response data.
@calvincestari calvincestari mentioned this issue Aug 10, 2023
Merged
@calvincestari calvincestari changed the title @defer label validation @defer label validation Aug 10, 2023
@calvincestari calvincestari added this to the `@defer` support milestone Aug 10, 2023
@calvincestari calvincestari mentioned this issue Aug 10, 2023
Closed
@calvincestari calvincestari self-assigned this Aug 31, 2023
@calvincestari calvincestari linked a pull request Aug 31, 2023 that will close this issue
feature: Require label argument on @defer directive apollographql/apollo-ios-dev#28
Merged
@calvincestari calvincestari mentioned this issue Aug 31, 2023
Merged
@calvincestari
Copy link
Member Author

Done with the merging of apollographql/apollo-ios-dev#28.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@calvincestari calvincestari

Labels
None yet
Projects
None yet
Milestone
`@defer` support
Development

Successfully merging a pull request may close this issue.

feature: Require label argument on @defer directive apollographql/apollo-ios-dev
1 participant
@calvincestari