Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSONDecodingError implementation of Matchable is missing the wrongType case. #366

Closed
fdiaz opened this issue Sep 14, 2018 · 0 comments · Fixed by #367
Closed

JSONDecodingError implementation of Matchable is missing the wrongType case. #366

fdiaz opened this issue Sep 14, 2018 · 0 comments · Fixed by #367

Comments

@fdiaz
Copy link
Contributor

fdiaz commented Sep 14, 2018 •
edited
Loading

While writing some tests we discovered JSONDecodingError implementation of Matchable is missing the wrongType case

https://github.com/apollographql/apollo-ios/blob/master/Sources/Apollo/JSON.swift#L43

Intended outcome:

JSONDecodingError.wrongType ~= JSONDecodingError.wrongType should return true.

Actual outcome:

JSONDecodingError.wrongType ~= JSONDecodingError.wrongType returns false.

How to reproduce the issue:

Write a simple test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix JSONDecodingError Matchable implementation fdiaz/apollo-ios
1 participant
@fdiaz