Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary AndroidX Multidex library included #5929

Closed
edenman opened this issue May 31, 2024 · 3 comments
Closed

Unnecessary AndroidX Multidex library included #5929

edenman opened this issue May 31, 2024 · 3 comments
Labels
🐛 Type: Bug

Comments

@edenman
Copy link
Contributor

edenman commented May 31, 2024

Version

4.0.0-beta.6

Summary

Updating from beta 4 and noticed a new androidx.multidex:multidex:2.0.1 dependency. Looks like it's added unconditionally in #5761

Could we make this optional? AFAICT it's only necessary on pre-21 https://developer.android.com/build/multidex#mdex-pre-l

Steps to reproduce the behavior

No response

Logs

(Your logs here)
@martinbonnin
Copy link
Contributor

martinbonnin commented May 31, 2024 •
edited
Loading

My bad, it should have been androidTestImplementation. Thanks for catching this, will update in a bit 🙏

@BoD
Copy link
Contributor

BoD commented Jun 12, 2024

Removed in #5930, available in 4.0.0-beta7

@BoD BoD closed this as completed Jun 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo Kotlin usage and allow us to serve you better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BoD @edenman @martinbonnin