using async in formatError hook, error message will be no complete

[anymost]

when I use async function in formatError hook, for example:
formatError:async (error) => { // some other async code console.log(error); return error; }
the error message sent to client don't contain error detail, just like this:
{ "data":null, "errors":[{}] }
if I remove async , the error message sent to client will be complete, wish some body help me, thanks a lot

[anymost]

I found calling the formatError function without async when I searched the source code, the code position is :

apollo-server/packages/apollo-server-errors/src/index.ts

Line 213 in 5f89702

export function formatApolloErrors(

[cheapsteak]

Hi there
Closing this issue because formatError does not support async functions
Curious if you could share your use-case? Perhaps you might benefit from the didEncounterErrors lifecycle that was recently added - #2719

[marlonfsolis]

Hi @cheapsteak,
Do you think is a valid scenario call an async method that log the error on a DB?
I think would be simpler than inplement didEncounterErrors. But I am not sure how hard would be to convert formatError to async function.
It was very hard to find out how to implement didEncounterErrors. The documentation does not provide a good example of how to implement this event lifecycle.
The formatError is more intuitive and simpler.

const formatError = async (formattedError:GraphQLFormattedError, error:unknown): GraphQLFormattedError => 
{
   const errorLogId = await logError(LogLevel.ERROR, formattedError.message);
   formattedError.message =+ ` - ErrorNo.: ${errorLogId }`;
   return formattedError;
}

[trevor-scheer]

@marlonfsolis didEncounterErrors is the correct approach for async logging. It looks like we have some examples for other hooks but not this one. TypeScript also makes working with our libraries easier. Tests are often a good place to look for examples (there are a few in our repo).

Here's the skeleton of a plugin which implements didEncounterErrors. Hope you find this helpful.

plugins: [{
  async requestDidStart() {
    return {
      async didEncounterErrors(requestContext) {
        // log to service
      }
    };
  } 
}]