Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling tracing wipes extension data, e.g. __queryPlanExperimental #4116

Closed
godspeedelbow opened this issue May 15, 2020 · 3 comments
Closed

Comments

@godspeedelbow
Copy link

godspeedelbow commented May 15, 2020

Spent some time trying to figure out why response.extensions.__queryPlanExperimental was getting removed from the response after it was set.

Basically, when config.tracing is set to true, it includes the TracingExtension which has a format method and which will override whatever was set on response.extensions.

The expected behavior is that extension data does not get wiped. Or if it is the intended behavior, then I think it makes sense if there's an extension hook that gets called with response data, so that an extension can pluck the data it needs, e.g. __queryPlanExperimental and then format that data with the format method.

@godspeedelbow
Copy link
Author

🦗 🦗

@abernix
Copy link
Member

abernix commented Jun 8, 2020

Can you try again with the latest version of Apollo Server, 2.14.1? The tracing extension was recently ported to the plugin API in Apollo Server 2.14.0 via #3991.

@glasser
Copy link
Member

glasser commented Oct 21, 2022

The tracing option and the TracingExtension (which created an old inefficient kind of inline trace) are no longer part of Apollo Server.

@glasser glasser closed this as completed Oct 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants