-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parsing headers as integer cause failed to send usage report to apollo studio #7289
Comments
content-length
headers as integer cause failed to send usage report to apollo studio
content-length
headers as integer cause failed to send usage report to apollo studio
Is it possible to simplify your reproduction? Remove dependencies on things like newrelic and dynamodb, get it to be as small as possible and still reproduce the error? I'd rather not have to set up a New Relic account for an issue that presumably doesn't depend on New Relic. (And ideally if it can be reproduced locally without deploying to AWS that would be great to know as well!) |
At a high level: the Apollo Server express middleware expects that the headers it receives should be strings or lists of strings. I do see a few places where I suggest opening a more explicit issue (or PR?) against I also see that this is fixed in serverless-adapter which is a more recent project that started as a fork of serverless-express. serverless-adapter actually has explicit built-in support for AS4 without even going through Express, so you might find that better than the vendia project. (It's definitely a newer and less widely used project though.) |
Issue Description
when sending all headers to apollo studio
apollo server parse some of the request headers value to integer(I only observed field
content-length
parsed to an integer, not sure if other fields are also able to convert to non-string value),headers below are the values we observed in code line during debugging
but usage report's proto-buf defined the header value as string
so we get the errors as bellow:
Link to Reproduction
https://github.com/Blankll/serverless-event
Reproduction Steps
follow the repo's readme to package & deploy it to aws, checke the cloudwatch you will see the error message
The text was updated successfully, but these errors were encountered: