-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment in code is misleading or code is wrong for parsing query if its already AST #833
Comments
See also: #722 - Our use case prefers it works as described, not as written. |
We're working on providing techniques to control the exact behavior, which has been facilitated by the work done in #1795. For what it's worth, the confusing comment you'd referred to:
...has been removed! |
We're working on providing techniques to control the exact behavior, which has been facilitated by the work done in #1795. The confusing comment you'd referred to:
...has been removed, so I'll close this. Thanks for reporting this originally! |
This is probably small catch - but maybe useful. Noticed that in here comment says if query is already an AST, don't parse or validate, but in fact it just skip the parsing step.
In our case it works as we want. Because we just want to do parse step outside of runHttpQuery to be able to read mutation name from it. But wanted to bring it up to make sure if it works as intended and the validation steps always happen there also in future.
The text was updated successfully, but these errors were encountered: