-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should not be new validateSchema called in runQuery? #936
Labels
🌹 has-reproduction
❤ Has a reproduction in Glitch, CodeSandbox or Git repository.
Comments
ghost
added
📚 good-first-issue
Issues that are more approachable for first-time contributors.
🌹 has-reproduction
❤ Has a reproduction in Glitch, CodeSandbox or Git repository.
labels
Apr 3, 2018
abernix
removed
the
📚 good-first-issue
Issues that are more approachable for first-time contributors.
label
Sep 21, 2018
Thanks for reporting this originally and sorry it's taken so long to triage this. I'll close this since most of the request pipeline has been overhauled in Apollo Server as #1795 and we haven't seen any recurring reports of this, but if you're still experiencing problems with this, please do open a new issue with a runnable reproduction (per the instructions when opening a new issue). Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
in graphql-js 0.12 schema validation was taken out from constructor and moved to
validateSchema
. Therefore it's used explicitly in wrapping function from 0.12.0. Did not find thatrunQuery
would be adjusted for this change, so its now basically skipping thisvalidationSchema
step. Is that intention or oversight?The text was updated successfully, but these errors were encountered: