Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should not be new validateSchema called in runQuery? #936

Closed
2 of 5 tasks
jardakotesovec opened this issue Apr 3, 2018 · 1 comment
Closed
2 of 5 tasks

should not be new validateSchema called in runQuery? #936

jardakotesovec opened this issue Apr 3, 2018 · 1 comment
Labels
🌹 has-reproduction ❤ Has a reproduction in Glitch, CodeSandbox or Git repository.

Comments

@jardakotesovec
Copy link

  • has-reproduction
  • feature
  • docs
  • blocking
  • good first issue

in graphql-js 0.12 schema validation was taken out from constructor and moved to validateSchema. Therefore it's used explicitly in wrapping function from 0.12.0. Did not find that runQuery would be adjusted for this change, so its now basically skipping this validationSchema step. Is that intention or oversight?

@ghost ghost added 📚 good-first-issue Issues that are more approachable for first-time contributors. 🌹 has-reproduction ❤ Has a reproduction in Glitch, CodeSandbox or Git repository. labels Apr 3, 2018
@abernix abernix removed the 📚 good-first-issue Issues that are more approachable for first-time contributors. label Sep 21, 2018
@abernix
Copy link
Member

abernix commented Jul 2, 2019

Thanks for reporting this originally and sorry it's taken so long to triage this.

I'll close this since most of the request pipeline has been overhauled in Apollo Server as #1795 and we haven't seen any recurring reports of this, but if you're still experiencing problems with this, please do open a new issue with a runnable reproduction (per the instructions when opening a new issue).

Thanks!

@abernix abernix closed this as completed Jul 2, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🌹 has-reproduction ❤ Has a reproduction in Glitch, CodeSandbox or Git repository.
Projects
None yet
Development

No branches or pull requests

2 participants