-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codegen should take @include and @skip into account #888
Comments
This would be really useful. If it'd be an easy PR I'm happy to have a go? |
Would love some help on this! |
This would be super useful! The @include directive trivialises a problem I'm dealing with but since I can't generate proper types using it I'm hesitant to use it. Could anyone point me in the right direction if I'd want to help out with resolving this? |
This would still be extremely useful! Without the proper types, we get incorrect signal on whether we need to check for undefined/null which can cause unexpected bugs. Would be happy to help contribute to this resolution. |
Anyone found a solution for having the typescript types be generated as nullable types when using directives? |
If we use
@include
or@skip
directives on a non-nullable field, the code generation output should be nullable because we can guarantee that the data won't always exist.The text was updated successfully, but these errors were encountered: