Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.8.1 #425

Merged
merged 16 commits into from
Jun 14, 2017
Merged

0.8.1 #425

merged 16 commits into from
Jun 14, 2017

Conversation

helfer
Copy link
Contributor

@helfer helfer commented Jun 13, 2017

Thanks to @DxCx for fixing a bug where queries over HTTP GET would not go through validation.

@helfer
Copy link
Contributor Author

helfer commented Jun 13, 2017

Oh, now I see what's going on. I thought it was my mistake, but Lerna is auto-updating dependencies. Well how nice of Lerna ... 🙄

Fibers v2 does't compile on Node 4, so we can't update it as long as we want to keep support for Fibers. Trying to find out how to keep Lerna from doing that, but might have to resume tomorrow.

"fibers": "^1.0.15",
"meteor-promise": "^0.8.2"
"@types/graphql": "^0.9.1",
"fibers": "^2.0.0",
Copy link
Contributor Author

@helfer helfer Jun 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line here is the problem. Fibers should not be updated. We might have to use a specific version range >= 1.0.15 < 2.0.0 here, but I don't know if that would work, and to test it we either have to dig through the lerna source, or try a new release...

@helfer
Copy link
Contributor Author

helfer commented Jun 13, 2017

Maybe we can downgrade to a version of lerna that doesn't do the auto-updating.

@DxCx
Copy link
Contributor

DxCx commented Jun 13, 2017

@helfer does it happen even if you request specified version?

@helfer
Copy link
Contributor Author

helfer commented Jun 13, 2017

Well, now that's clearly a bug and not consistent with the lerna docs... Updating fibers=1.0.15 to 2.0.0

@helfer
Copy link
Contributor Author

helfer commented Jun 14, 2017

Ah, I found the issue. It has nothing to do with Lerna at all. It's the prerelease script in package.json. @DxCx what was the rationale for adding check-updates to the lerna release cycle? In other words, if I remove it, are we losing anything? I'd rather have something like greenkeeper take care of the dependencies.

@DxCx
Copy link
Contributor

DxCx commented Jun 14, 2017 via email

@helfer
Copy link
Contributor Author

helfer commented Jun 14, 2017

Haha, I guess we both forgot about it! Well I've removed it for now because it was causing problems with fibers. We'll need to find another way to keep dependencies updated if we can't pin a certain version. In any case, I think we should run the version updates manually so we can fix them by hand if necessary.

@helfer helfer merged commit 1a76431 into master Jun 14, 2017
@helfer helfer deleted the 0.8.1 branch June 14, 2017 06:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants