Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphiQL: Allow full websocket mode #491

Merged
merged 3 commits into from
Aug 1, 2017
Merged

GraphiQL: Allow full websocket mode #491

merged 3 commits into from
Aug 1, 2017

Conversation

DxCx
Copy link
Contributor

@DxCx DxCx commented Jul 31, 2017 •
edited
Loading

Changes in this PR:

  • Update GraphiQL to use latest packages:
    • subscription-transport-ws = 0.8.2
    • fetch = 2.0.1
    • react = 15.6.1
  • use websocket transport request method incase endpointURL starts with ws://
    (Full WebSocket mode)
  • keep legacy api (endpointURL=http, subscriptionsEndpoint=ws) working exactly like before.
  • bug fix for undefined graphiql variables set into url.

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@DxCx DxCx force-pushed the full-ws-graphiql branch from 8e64cbc to fa76131 Compare July 31, 2017 15:45
@DxCx DxCx requested a review from freiksenet August 1, 2017 09:32
@martijnwalraven martijnwalraven merged commit 2736828 into apollographql:master Aug 1, 2017
@DxCx DxCx deleted the full-ws-graphiql branch August 1, 2017 23:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@freiksenet freiksenet Awaiting requested review from freiksenet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DxCx @martijnwalraven