Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom GraphQLScalarType not used on mergedSchemas. #1200

Closed
ThanosDi opened this issue Sep 13, 2019 · 4 comments
Closed

custom GraphQLScalarType not used on mergedSchemas. #1200

ThanosDi opened this issue Sep 13, 2019 · 4 comments
Labels

Comments

@ThanosDi
Copy link

Example using a custom scalar type without mergeSchemas is working correctly : https://codesandbox.io/s/custom-scalar-type-jewe1

Example using a custom scalar type with mergeSchemas is not working: https://codesandbox.io/s/custom-scalar-type-p831z

Any idea how I can address this issue?
Thank you.

@ThanosDi ThanosDi changed the title GraphQLScalarType not used on mergedSchemas. custom GraphQLScalarType not used on mergedSchemas. Sep 13, 2019
@yaacovCR
Copy link
Collaborator

yaacovCR commented Sep 19, 2019

In graphql tools version of mergeSchemas, custom scalars are not parsed, just passed through, a problem for gateway logic.

yaacovCR@2ec9ac2

Fixed in graphql tools fork

https://www.npmjs.com/package/graphql-tools-fork

@TimSusa
Copy link

TimSusa commented Mar 21, 2020

Why just not taking over graphql-tools-fork fixes to graphql-tools? Really hard for me to understand, just to say its deprecated. Seems to me, like a sad story.

@kamilkisiela
Copy link
Collaborator

We recently released an alpha version of GraphQL Tools (#1308) that should fix the issue.

Please update graphql-tools to next or run:

npx match-version graphql-tools next

Let us know if it solves the problem, we're counting for your feedback! :)

@yaacovCR yaacovCR mentioned this issue Mar 27, 2020
22 tasks
@yaacovCR
Copy link
Collaborator

Rolled into #1306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants