-
-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support merging of schema directives #1003
Conversation
I'm looking forward to this feature and tried your PR, but I get the following error: const schema = makeExecutableSchema({
typeDefs: `
directive @auth(role: Role = ADMIN) on OBJECT | FIELD_DEFINITION
enum Role {
ADMIN
USER
PUBLIC
}
type User {
firstname: String @auth(role: PUBLIC)
lastname: String
}
type Query {
user: User
}
`
});
const merged = mergeSchemas({ schemas: [schema], mergeDirectives: true });
|
@Torsten85 thanks a lot, I'll check it and add fix+test for it. |
8141732
to
c0e4f1a
Compare
@Torsten85 Fixed, is it working for you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍@hwillson should confirm too though
I too waiting for this PR to get merge, please let me know ETA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for working on this @freiksenet!
* Support merging of schema directives * Update CHANGELOG.md * Add missing branch * Fix recreation of directives
* Support merging of schema directives * Update CHANGELOG.md * Add missing branch * Fix recreation of directives
Add support to merging directive definitions in mergeSchemas.
TODO: