Use defaultFieldResolver from graphql-js package instead of own one #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitri-koenig
force-pushed
the
feature/defaultFieldResolver
branch
from
6a690ea
to
db6ff47
Compare
|
@stubailo: do you mind merging this PR though some minor coverage decrease has been detected? |
|
Sure thing! Weird that it failed the status with that small of a change. |
|
@dimitri-koenig do you mind sending a PR to the changelog as well? |
dimitri-koenig
added a commit
to dimitri-koenig/graphql-tools
that referenced
this pull request
Aug 14, 2017
|
@stubailo: Done. Please merge again. Any idea about a date of the next official release? // Edit: need another standalone PR |
dimitri-koenig
added a commit
to dimitri-koenig/graphql-tools
that referenced
this pull request
Aug 14, 2017
stubailo
pushed a commit
that referenced
this pull request
Aug 14, 2017
|
@martijnwalraven or @freiksenet can publish! |
|
@dimitri-koenig: Just published v1.2.0! |
|
@martijnwalraven & @stubailo: you are awesome. That way open source work is really so much fun. Efficient, effective and fast. Thank you so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of defaultFieldResolver of graphql-js package instead own one.
Should fix #368 as soon as this PR is merged: graphql/graphql-js#980